refactor: Secure and stabilize File Management System #37

Manually merged

Notarin merged 1 commit from notarin/refactor into FileSystemRework

2026-09-13 13:13:54 +00:00

AGit

Notarin commented

2026-09-12 16:57:43 +00:00

Contributor

Security fixes:

Add network OOM protection (10MB max file size with buffer validation)
Replace EndOfStreamException with InvalidOperationException for sandbox compliance

Performance fixes:

Replace string concatenation with StringBuilder
Move client disk IO to Task.Run

Stability fixes:

Clean up callback queues on player disconnect to prevent memory leaks
LINQ -> manual array population

Architecture improvements:

Replace PostInject with Initialize
Move server to use direct state refresh instead of having to use network refresh events
Remove ShipyardConsoleRefreshMessage and associated listener
Split ShipFileManagerOptions and ApartmentFileManagerOptions

Security fixes: - Add network OOM protection (10MB max file size with buffer validation) - Replace EndOfStreamException with InvalidOperationException for sandbox compliance Performance fixes: - Replace string concatenation with StringBuilder - Move client disk IO to Task.Run Stability fixes: - Clean up callback queues on player disconnect to prevent memory leaks - LINQ -> manual array population Architecture improvements: - Replace PostInject with Initialize - Move server to use direct state refresh instead of having to use network refresh events - Remove ShipyardConsoleRefreshMessage and associated listener - Split ShipFileManagerOptions and ApartmentFileManagerOptions

Notarin added 1 commit

2026-09-12 16:57:43 +00:00

refactor: Secure and stabilize File Management System

Close PRs on master / run (pull_request_target) Has been skipped

Details

Check Merge Conflicts / Add (pull_request_target) Has been cancelled

Details

Labels: PR / labeler (pull_request_target) Has been cancelled

Details

CRLF Check / CRLF Check (pull_request) Has been cancelled

Details

RGA schema validator / YAML RGA schema validator (pull_request) Has been cancelled

Details

Map file schema validator / YAML map schema validator (pull_request) Has been cancelled

Details

YAML Linter / YAML Linter (pull_request) Has been cancelled

Details

PR Changelogs / changelog (pull_request_target) Has been cancelled

Details

0073942721

Security fixes:
- Add network OOM protection (10MB max file size with buffer validation)
- Replace EndOfStreamException with InvalidOperationException for sandbox compliance

Performance fixes:
- Replace string concatenation with StringBuilder
- Move client disk IO to Task.Run

Stability fixes:
- Clean up callback queues on player disconnect to prevent memory leaks
- LINQ -> manual array population

Architecture improvements:
- Replace PostInject with Initialize
- Move server to use direct state refresh instead of having to use network refresh events
- Remove ShipyardConsoleRefreshMessage and associated listener
- Split ShipFileManagerOptions and ApartmentFileManagerOptions

Notarin commented

2026-09-12 16:59:56 +00:00

Author

Contributor

Normally I would amend your commit, but I felt it would be easier for you to actually review my changes if it was a commit on top.
If&when merged in, I will squash the two, before you then break it up into more digestible commits.

Normally I would amend your commit, but I felt it would be easier for you to actually review my changes if it was a commit on top. If&when merged in, I will squash the two, before you then break it up into more digestible commits.

Notarin manually merged commit 0073942721 into FileSystemRework

2026-09-13 13:13:54 +00:00