HardLight/HardLight
Watch
25
5
Fork
You've already forked HardLight
 86
Code Issues 201 Pull requests 49 Projects 3 Wiki Activity Actions 4

hotfix: Fix YAMLLinter being unable to index SaveBanPrototype #4535

Merged
Notarin merged 2 commits from notarin/Hotfix: Fix YAMLLinter being unable to index SaveBanPrototype into master 2026-08-29 09:31:48 +00:00 AGit
Conversation 1 Commits 2 Files changed 4 +48 -47
Notarin commented 2026-08-29 00:19:59 +00:00
Member

Turns out, prototype kinds are only permitted in shared.
There is no such thing as server-side or client-side prototype kinds.
This is entirely undocumented afaik.
We should probably implement a test to ensure others do not make the same mistake.

Turns out, prototype kinds are only permitted in shared. There is no such thing as server-side or client-side prototype kinds. This is entirely undocumented afaik. We should probably implement a test to ensure others do not make the same mistake.
Turns out, prototype kinds are only permitted in shared.
There is no such thing as server-side or client-side prototype kinds.
This is entirely undocumented afaik.
We should probably implement a test to ensure others do not make the same mistake.
Remove ColsecEquipment saveban null components field
All checks were successful
Close PRs on master / run (pull_request_target) Has been skipped
Details
Check Merge Conflicts / Add (pull_request_target) Successful in 22s
Details
Labels: Size / size-label (pull_request_target) Successful in 3s
Details
Labels: Untriaged / add_label (pull_request_target) Successful in 7s
Details
CRLF Check / CRLF Check (pull_request) Successful in 1m6s
Details
RGA schema validator / YAML RGA schema validator (pull_request) Successful in 1m22s
Details
Labels: PR / labeler (pull_request_target) Successful in 8s
Details
Build & Test Debug / Build Client & Server (pull_request) Successful in 15m11s
Details
Map file schema validator / YAML map schema validator (pull_request) Successful in 5m48s
Details
YAML Linter / YAML Linter (pull_request) Successful in 5m49s
Details
Build & Test Debug / Build & Test Debug (pull_request) Successful in 1s
Details
PR Changelogs / changelog (pull_request_target) Successful in 1m13s
Details
5c2a21a54e
 
Accidental addition, "null" fields should simply not be defined, so the prototype kind may handle its default value.
Notarin changed title from Remove ColsecEquipment saveban null components field to Hotfix: Fix YAMLLinter being unable to index SaveBanPrototype 2026-08-29 00:40:18 +00:00
Cheep approved these changes 2026-08-29 03:05:42 +00:00
Notarin changed title from Hotfix: Fix YAMLLinter being unable to index SaveBanPrototype to hotfix: Fix YAMLLinter being unable to index SaveBanPrototype 2026-08-29 04:45:36 +00:00
Notarin merged commit 93cf766a69 into master 2026-08-29 09:31:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Cheep
Labels
Clear labels   
Balance
This change must be approved by the balance team.

  
Bug
Reporting or addressing unintended behavour.

  
DB Migration
Associated with a database migration, keeping the database lockstep with the code.

  
Direction Consensus Required
Directorate must come to a consensus before this change is introduced to the game.

  
Docs
Relevant to, or changes documentation.

  
Feature
Pertaining to an addition to behavour.

  
Feature Discussion
Either linked to one, or is an issue hosting a discussion on the approach to take for a feature.

  
Map
The change modifies map file(s).

  
No C#
The change makes no changes to C# code.

  
No YML

   
Patreon
Related to a patrons benefits.

  
Port
Either pertaining to, or is, either a trnslations, or reimplementation of a feature or change from another SS14 derivative server, or SS14 itself.

  
QoL
Quality of Life improvement.

  
Ships
Associated with ships/shuttles.

  
Soft-Port
Similar to `Port`, but is from a work that isn't SS14 or SS14-derivative. Typically from SS13.

  
Spriting
This issue or PR involves sprite work.

  
triage: P0 Drop Everything
An outstanding issue so drastic it simply cannot wait, it MUST be attended to immediately.

  
triage: P1 Critical
An outstanding issue that is causing frequent or constant significant inconvenience.

  
triage: P2 Urgent
An active issue that occasionally afflicts players, or renders a subsystem unavailable.

  
triage: P3 When Available
The most "normal" or typical priority. For issues/PRs that can reasonably be ignored by even afflicted players.

  
triage: P4 When Nothing Available
bottom barrel priority. Only work on this when bored.

  
triage: P5 Optional
issues/PRs that can be ignored indefinantly should it interest no maintainer

No labels
Balance
Bug
DB Migration
Direction Consensus Required
Docs
Feature
Feature Discussion
Map
No C#
No YML
Patreon
Port
QoL
Ships
Soft-Port
Spriting
triage: P0 Drop Everything
triage: P1 Critical
triage: P2 Urgent
triage: P3 When Available
triage: P4 When Nothing Available
triage: P5 Optional
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
HardLight/HardLight!4535
No description provided.